Cleanup: Connection cancel -> shutdown #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
changed the title
glbrntt
approved these changes
Jul 23, 2021
Comment on lines
66
to
68
| return connection.execute(request: request) | ||
| case .http2(let connection): | ||
| return connection.executeRequest(request) |
There was a problem hiding this comment.
That's some mildly irritating asymmetry :)
| case .__testOnly_connection: | ||
| break | ||
| } | ||
| } | ||
|
|
||
| fileprivate func cancel() { | ||
| /// Closes the connection without cancelling running requests. |
There was a problem hiding this comment.
What happens to the requests if we don't cancel them? Why would do use this over shutdown?
There was a problem hiding this comment.
In the pool state machine, we know if a connection is idle or not. For this reason, we can use the direct way to close, if we are sure nothing is running on the connection.
glbrntt
approved these changes
Jul 23, 2021
Lukasa
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
cancelconnection toshutdown, with an explicit code comment.http1_1and.http2cases toHTTPConnectionPool.Connection